Re: [PATCH 0/4] amd64_edac: misc fixes

From: H. Peter Anvin
Date: Mon Jun 01 2009 - 14:58:38 EST


Borislav Petkov wrote:
> Actually, popcnt got added to gas in July 2006 so checking the gas
> version should suffice, IMHO.

gas is part of binutils.

> Anyway, I proposed something similar before but Andrew suggested that we
> should simply slap in the opcode so we don't need the Kbuild changes.
> The advantage of the approach is that it works unconditionally on all
> toolchains and introduces less code changes. Hmm...

That really sucks, though, in the long run. I personally prefer to have
the "right thing" -- which in this case is probably gcc intrinsics --
and then a fallback that will gradually fall out of use.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/