Re: [PATCH] Re: 'make headers_check' failed to install headers to arbitrary location

[Wolfgang Denk]

Dear Sergei,

In message <20090604175536.2a1d0add@xxxxxxxxxxx> you wrote:
> 
> Here is another version of the patch which fixes
> the "Argument list too long" error for "make headers_check", used xargs
> to minimize the perl calls (thanks, Wolfgang).

Hm... but now we have a useless use of cat and a temp file.

> -      cmd_check = $(PERL) $< $(INSTALL_HDR_PATH)/include $(SRCARCH) \
> -                  $(addprefix $(install)/, $(all-files));           \
> +# Headers list can be pretty long, xargs helps to avoid
> +# the "Argument list too long" error.
> +      cmd_check = rm -f hdrlist; touch hdrlist;                      \
> +                  for f in $(all-files); do                          \
> +                  echo "$(install)/$${f} " >> hdrlist; done;         \
> +                  cat hdrlist | xargs                                \
> +                  $(PERL) $< $(INSTALL_HDR_PATH)/include $(SRCARCH); \
> +                  rm -f hdrlist;                                     \

Why not simply:

	for f in $(all-files); do
		echo "$(install)/$${f}"
	done | xargs $(PERL) ...

?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@xxxxxxx
A witty saying proves nothing, but saying  something  pointless  gets
people's attention.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/