Re: [PATCH] proc: vmcore - use kzalloc in get_new_element

[Vivek Goyal]

On Sat, Jun 06, 2009 at 09:12:07PM +0400, Cyrill Gorcunov wrote:
> Instead of kmalloc+memset better use straight kzalloc
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
> ---
>  fs/proc/vmcore.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> Index: linux-2.6.git/fs/proc/vmcore.c
> =====================================================================
> --- linux-2.6.git.orig/fs/proc/vmcore.c
> +++ linux-2.6.git/fs/proc/vmcore.c
> @@ -166,12 +166,7 @@ static const struct file_operations proc
>  
>  static struct vmcore* __init get_new_element(void)
>  {
> -	struct vmcore *p;
> -
> -	p = kmalloc(sizeof(*p), GFP_KERNEL);
> -	if (p)
> -		memset(p, 0, sizeof(*p));
> -	return p;
> +	return kzalloc(sizeof(struct vmcore), GFP_KERNEL);
>  }
>  
>  static u64 __init get_vmcore_size_elf64(char *elfptr)

Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx>

Thanks
Vivek

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/