Re: [PATCH 0/5] We must use rcu_barrier() on module unload

From: Patrick McHardy
Date: Mon Jun 08 2009 - 10:00:45 EST


Jesper Dangaard Brouer wrote:
If an unloadable module uses RCU callbacks, it need to use
rcu_barrier() so that the module may be safely unloaded.

While hacking on a netfilter module of my own, I learned the
importance of calling rcu_barrier() instead of only a
synchronize_rcu() on module unload (iif using any call_rcu()
callbacks). synchronize_rcu() does wait for a grace period to
elapse, but it does not wait for the callbacks to complete.

...
I have made a patch for each individual module, so objections can be
made on a per module basis. I have Cc'ed all of the patches to the
maintainers of each module (according to the MAINTAINERS file).

Acked-by: Patrick McHardy <kaber@xxxxxxxxx> for patches 1 and 2, good
catch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/