Re: [PATCH v3] add MAX17040 Fuel Gauge driver

[Minkyu Kang]

Dear, Anton Vorontsov

2009/6/9 Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>:
> On Mon, Jun 08, 2009 at 11:36:01AM +0900, Minkyu Kang wrote:
>> Dear Trilok Soni,
>>
>> Thanks for review
>>
>> > Hi Minkyu Kang,
>> >
>> > On Fri, Jun 5, 2009 at 12:03 PM, Minkyu Kang<mk7.kang@xxxxxxxxxxx> wrote:
>> >> The MAX17040 is a I2C interfaced Fuel Gauge systems for lithium-ion batteries
>> >> This patch adds support the MAX17040 Fuel Gauge
>> >>
>> >
>> > Thanks for making change. Some more comments.
>> >
>> >>  endif # POWER_SUPPLY
>> >> diff --git a/drivers/power/Makefile b/drivers/power/Makefile
>> >> index 2fcf41d..9c48995 100644
>> >> --- a/drivers/power/Makefile
>> >> +++ b/drivers/power/Makefile
>> >> @@ -25,4 +25,5 @@ obj-$(CONFIG_BATTERY_TOSA)    += tosa_battery.o
>> >>  obj-$(CONFIG_BATTERY_WM97XX)   += wm97xx_battery.o
>> >>  obj-$(CONFIG_BATTERY_BQ27x00)  += bq27x00_battery.o
>> >>  obj-$(CONFIG_BATTERY_DA9030)   += da9030_battery.o
>> >> -obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o
>> >> \ No newline at end of file
>> >> +obj-$(CONFIG_BATTERY_MAX17040))        += max17040_battery.o
>
> There is a typo: "))" should be just ")". I fixed this.
>
> I also fixed "‘max17040_set_rcomp’ defined but not used" warning
> (just removed this function).

I missed it. thanks.

>> > Are we following any alphabetical order in this Makefile?
>> >
>>
>> I'm not sure either. :(
>> I just grouping with batteries.
>
> It's fine as is. I always wonder when somebody try to sort things
> alphabetically. Humans should not bother with sorting, that's what
> computers are for! ;-)
>
>> >> +static int max17040_suspend(struct i2c_client *client,
>> >> +               pm_message_t state)
>> >> +{
>> >> +       struct max17040_chip *chip = i2c_get_clientdata(client);
>> >> +
>> >> +       cancel_delayed_work(&chip->work);
>> >> +       return 0;
>> >> +}
>> >> +
>> >> +static int max17040_resume(struct i2c_client *client)
>> >> +{
>> >> +       struct max17040_chip *chip = i2c_get_clientdata(client);
>> >> +
>> >> +       schedule_delayed_work(&chip->work, MAX17040_DELAY);
>> >> +       return 0;
>> >> +}
>> >> +
>> >
>> > Please add #ifdef CONFIG_PM around suspend resume functions.
>> >
>>
>> Ok, I will.
>
> Just did it myself, and queued this patch for 2.6.31.
>
> Thanks!
>

Ok, I appreciate your help.
Many Thanks :)

-- 
from. prom.
promsoft.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/