Re: [PATCH mmotm] vmscan: handle may_swap more strictly (Re: [PATCH mmotm] vmscan: fix may_swap handling for memcg)

[Minchan Kim]

Hi, KOSAKI.

As you know, this problem caused by if condition(priority) in shrink_zone.
Let me have a question.

Why do we have to prevent scan value calculation when the priority is zero ?
As I know, before split-lru, we didn't do it.

Is there any specific issue in case of the priority is zero ?

On Tue, Jun 9, 2009 at 4:20 PM, KOSAKI
Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
>> > > and, too many recliaming pages is not only memcg issue. I don't think this
>> > > patch provide generic solution.
>> > >
>> > Ah, you're right. It's not only memcg issue.
>> >
>> How about this one ?
>>
>> ===
>> From: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
>>
>> Commit 2e2e425989080cc534fc0fca154cae515f971cf5 ("vmscan,memcg: reintroduce
>> sc->may_swap) add may_swap flag and handle it at get_scan_ratio().
>>
>> But the result of get_scan_ratio() is ignored when priority == 0,
>> so anon lru is scanned even if may_swap == 0 or nr_swap_pages == 0.
>> IMHO, this is not an expected behavior.
>>
>> As for memcg especially, because of this behavior many and many pages are
>> swapped-out just in vain when oom is invoked by mem+swap limit.
>>
>> This patch is for handling may_swap flag more strictly.
>>
>> Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
>
> Looks great.
> your patch doesn't only improve memcg, bug also improve noswap system.
>
> Thanks.
> Â Â Â ÂReviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
>
>
>
>> ---
>> Âmm/vmscan.c | Â 18 +++++++++---------
>> Â1 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index 2ddcfc8..bacb092 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -1407,13 +1407,6 @@ static void get_scan_ratio(struct zone *zone, struct scan_control *sc,
>> Â Â Â unsigned long ap, fp;
>> Â Â Â struct zone_reclaim_stat *reclaim_stat = get_reclaim_stat(zone, sc);
>>
>> - Â Â /* If we have no swap space, do not bother scanning anon pages. */
>> - Â Â if (!sc->may_swap || (nr_swap_pages <= 0)) {
>> - Â Â Â Â Â Â percent[0] = 0;
>> - Â Â Â Â Â Â percent[1] = 100;
>> - Â Â Â Â Â Â return;
>> - Â Â }
>> -
>> Â Â Â anon Â= zone_nr_pages(zone, sc, LRU_ACTIVE_ANON) +
>> Â Â Â Â Â Â Â zone_nr_pages(zone, sc, LRU_INACTIVE_ANON);
>> Â Â Â file Â= zone_nr_pages(zone, sc, LRU_ACTIVE_FILE) +
>> @@ -1511,15 +1504,22 @@ static void shrink_zone(int priority, struct zone *zone,
>> Â Â Â enum lru_list l;
>> Â Â Â unsigned long nr_reclaimed = sc->nr_reclaimed;
>> Â Â Â unsigned long swap_cluster_max = sc->swap_cluster_max;
>> + Â Â int noswap = 0;
>>
>> - Â Â get_scan_ratio(zone, sc, percent);
>> + Â Â /* If we have no swap space, do not bother scanning anon pages. */
>> + Â Â if (!sc->may_swap || (nr_swap_pages <= 0)) {
>> + Â Â Â Â Â Â noswap = 1;
>> + Â Â Â Â Â Â percent[0] = 0;
>> + Â Â Â Â Â Â percent[1] = 100;
>> + Â Â } else
>> + Â Â Â Â Â Â get_scan_ratio(zone, sc, percent);
>>
>> Â Â Â for_each_evictable_lru(l) {
>> Â Â Â Â Â Â Â int file = is_file_lru(l);
>> Â Â Â Â Â Â Â unsigned long scan;
>>
>> Â Â Â Â Â Â Â scan = zone_nr_pages(zone, sc, l);
>> - Â Â Â Â Â Â if (priority) {
>> + Â Â Â Â Â Â if (priority || noswap) {
>> Â Â Â Â Â Â Â Â Â Â Â scan >>= priority;
>> Â Â Â Â Â Â Â Â Â Â Â scan = (scan * percent[file]) / 100;
>> Â Â Â Â Â Â Â }
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



-- 
Kinds regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/