Re: [PATCH 4/8] tracing/events: modify irq print to new format

[Steven Rostedt]

On Wed, 10 Jun 2009, Frederic Weisbecker wrote:
> >  
> >  /**
> > @@ -106,8 +106,8 @@ TRACE_EVENT(softirq_entry,
> >  		__entry->vec = (int)(h - vec);
> >  	),
> >  
> > -	TP_printk("softirq=%d action=%s", __entry->vec,
> > -		  show_softirq_name(__entry->vec))
> > +	TP_FORMAT("softirq=<int:vec> action=<sym:vec:" show_softirq_name_format(),
> 
> 
> Just to zap the confusion, I would suggest to explicitly close the '>' here instead
> of inside the macro. The current state suggests a kind of imbalance at a first glance.
> 
> 
> > +		  show_softirq_name_args())
> >  );
> >  
> >  /**
> > @@ -135,8 +135,8 @@ TRACE_EVENT(softirq_exit,
> >  		__entry->vec = (int)(h - vec);
> >  	),
> >  
> > -	TP_printk("softirq=%d action=%s", __entry->vec,
> > -		  show_softirq_name(__entry->vec))
> > +	TP_FORMAT("softirq=<int:vec> action=<sym:vec:" show_softirq_name_format(),
> 
> 
> And ditto.
> 

Ah, yeah right. Now that I have the formats separated, I can do that. The 
first patch had it as one (format and args). I'll add a separate patch in 
my next set of patches that build on top of this one.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/