Re: [PATCH 0/2] [GIT PULL] tracing/events/ring-buffer: block tracepoints and fix

[Steven Rostedt]

On Wed, 10 Jun 2009, Li Zefan wrote:

> >>> In file included from mm/highmem.c:30:
> >>> include/linux/blktrace_api.h:223: warning: ?struct request? declared inside parameter list
> >>> include/linux/blktrace_api.h:223: warning: its scope is only this definition or declaration, which is probably not what you want
> >>> include/linux/blktrace_api.h: In function ?blk_cmd_buf_len?:
> >>> include/linux/blktrace_api.h:225: error: implicit declaration of function ?blk_pc_request?
> >>> include/linux/blktrace_api.h:225: error: dereferencing pointer to incomplete type
> >>> include/linux/blktrace_api.h: At top level:
> >>> include/linux/blktrace_api.h:228: warning: ?struct request? declared inside parameter list
> >>> include/linux/blktrace_api.h:230: warning: ?struct request? declared inside parameter list
> >>> distcc[15629] ERROR: compile mm/highmem.c on a/32 failed
> >>>
> >> I've fixed it. I'll post a new version after I've done some
> >> more building tests.
> > 
> > Ingo,
> > 
> > Should Li post a delta fix, or should we just rebase?
> > 
> 
> I thought we should rebase it, since it causes building failure which
> might hurt bisectability.

The failure happens when CONFIG_BLOCK is not defined. How many configs 
really do that?

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/