Re: [PATCH 23/24] GFS2: Fix locking issue mounting gfs2meta fs

[Steven Whitehouse]

Hi,

On Wed, 2009-06-10 at 05:53 -0400, Christoph Hellwig wrote:
> On Wed, Jun 10, 2009 at 09:31:04AM +0100, Steven Whitehouse wrote:
> >  static struct super_block *get_gfs2_sb(const char *dev_name)
> >  {
> > -	struct super_block *sb;
> 
> Any reason you don't merge get_gfs2_sb into gfs2_get_sb_meta?  That's
> how most other get_sb callbacks are structured, and would also get rid
> of the rather confusing get_gfs2_sb name.
> 

Well originally I was expecting to share that code with the
gfs2_get_sb() but since that patch has been dropped now, I guess there
is no reason not to merge them,

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/