Re: [PATCH] X86: cpu_debug support for VIA / Centaur CPU's

[Ingo Molnar]

* H. Peter Anvin <hpa@xxxxxxxxxx> wrote:

> Ingo Molnar wrote:
> > 
> > MSRs should really be enumerated along CPU features. They will be 
> > accessed if a CPU offers that CPU feature.
> > 
> 
> Nice in theory, but so many MSRs have to be enumerated with obscure test
> combinations, that it really isn't practical in the general case.  That
> is why we have the safe MSR variants.
> 
> > 
> > Yeah, the safe read should never fault - there should be all 
> > zeroes or an error return.
> > 
> 
> Error return, MSRs #GP if not present.  All zero means a present 
> MSR (which is zero.)

yes, of course - i meant the /debug/x86/cpu/* behavior: it should 
either result zeroes, or should return -EINVAL. (probably the 
latter)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/