Re: [PATCH][GIT PULL] tracing: do not translate event helper macrosin print format

From: Steven Rostedt
Date: Thu Jun 11 2009 - 09:04:25 EST



On Thu, 11 Jun 2009, Christoph Hellwig wrote:

> On Wed, Jun 10, 2009 at 10:48:02PM +0200, Ingo Molnar wrote:
> > > This looks like it changed more than it really did, I only moved
> > > the one macro above another and added a few lines:
> > >
> > > +#undef __print_symbolic
> > > +#undef __get_dynamic_array
> > > +#undef __get_str
>
> > > tracing: do not translate event helper macros in print format
> > >
> > > By moving the macro that creates the print format code above the
> > > defining of the event macro helpers (__get_str, __print_symbolic,
> > > and __get_dynamic_array), we get a little cleaner print format.
>
> __print_flags should also be added, shouldn't it?

Darn, I knew I forgot one :-/

>
> Maybe also le/be*_to_cpu/cpu_to_le/be*? and major/minor?

We can only include macros that we define later. Otherwise we undefine
them for when we need them.

-- Steve

>
> We should also document those helpers that need special treatment
> somewhere?
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/