Re: [PATCH for tip/mce3] x86, mce: Add options for corrected errors

[Hidetoshi Seto]

Ingo Molnar wrote:
> * Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx> wrote:
>> [ Repost, rebased on tip/x86/mce3]
>>
>> This patch introduces three boot options (no_cmci, dont_log_ce and 
>> ignore_ce) to control handling for corrected errors.
(snip)
> 
> Applied to tip:x86/mce3, thanks Hidetoshi!

It's a pleasure!

> A few sidenote:
> 
> Please introduce a sysctl for these too, for those were the flag can 
> be safely toggled after bootup (most of them look to be such flags). 
> Admins might want to tweak these options without rebooting the 
> system.
> 
> Even for those flags where a toggle means having to touch MSRs to 
> deactivate/(reactivate) CMCI we should do the sysctl thing, as 
> no-reboot configurability is king in this space.

Once I had a sysctl patch but that was for previous version of these
options, so now it will not suitable...
OK, I'll reinvent that one.  Please wait.

> a few random details:
> 
>>  static int			mce_bootlog = -1;
>>  static int			monarch_timeout = -1;
>>  static int			mce_panic_timeout;
>> +static int			mce_dont_log_ce;
>> +int				mce_cmci_disabled;
>> +int				mce_ignore_ce;
>>  int				mce_ser;
> 
> All rarely-modified variables should be declared __read_mostly.

True.  I'll make a incremental patch for these.

>>  static char			trigger[128];
> 
> Undocumented magic constant and meaninglessly named global variable, 
> please clean this up.

It looks like it is.  This variable was introduced by:
 commit a98f0dd34d94ea0b5f3816196bea5dba467827bb

I'll check the history and make a patch for this to rename, add comment
or so.


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/