Re: [PATCH] crypto: add optional continuous repetition test toentropy store based rngs

[Matt Mackall]

On Sat, 2009-06-13 at 00:26 +1000, Herbert Xu wrote:
> On Fri, Jun 12, 2009 at 10:23:08AM -0400, Neil Horman wrote:
> >
> > > Ok, that seems like a reasonable idea.  new patch below
> > > Change Notes:
> > > 
> > > 1) Moved fips_enabled flag into its own header, included in all the appropriate
> > > places
> > > 
> > > 2) removed flags field from entropy store, keying continuous test on the
> > > non-null status of the last_data pointer
> > > 
> > > 
> > > FIPS-140 requires that all random number generators implement continuous self
> > > tests in which each extracted block of data is compared against the last block
> > > for repetition.  The ansi_cprng implements such a test, but it would be nice if
> > > the hw rng's did the same thing.  Obviously its not something thats always
> > > needed, but it seems like it would be a nice feature to have on occasion. I've
> > > written the below patch which allows individual entropy stores to be flagged as
> > > desiring a continuous test to be run on them as is extracted.  By default this
> > > option is off, but is enabled in the event that fips mode is selected during
> > > bootup.
> > > 
> > > Neil
> > > 
> > > Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
> > > 
> > Ping, I don't see that this got picked up in the crypto tree.  Are there
> > subsequent objections?
> 
> Matt, are you OK with me picking this up or do you want to pick it
> up?

Acked-by: Matt Mackall <mpm@xxxxxxxxxxx>

You can pick it up. Speaking of, do you care if I route other RNG bits
through your crypto tree? I usually just bounce patches to Andrew.

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/