Re: [PATCH 7/7] mmc: tmio_mmc: allow compilation for ASIC3

[pHilipp Zabel]

On Fri, Jun 12, 2009 at 11:47 PM, Ian molton<spyro@xxxxxxx> wrote:
> Does this patch actually _do_ anything? wont the asic3 driver need modifying
> to use tmio_mmc before this patch is useful?

That's right, this patch only allows tmio-mmc to be compiled on ASIC3
based devices. The needed changes to ASIC3
(http://patchwork.kernel.org/patch/28000/ et al) are queued in the MFD
tree.

> Is the idea that this patch go in and asic3 MFDs migrate gradually?

The idea was that this patch is applied after tmio-mmc is ASIC3-ready,
so that it doesn't matter whether the MFD or MMC tree gets merged
first. If the ASIC3 MFD changes come first, at least tmio-mmc won't be
built (for CONFIG_MFD_ASIC3) until the tmio-mmc modifications are in.

> If so then I'll ack it.
>
> Philipp Zabel wrote:
>>
>> Now tmio_mmc is able to drive the MMC/SD cell in ASIC3.
>>
>> Signed-off-by: Philipp Zabel <philipp.zabel@xxxxxxxxx>
>> Cc: Pierre Ossman <pierre@xxxxxxxxx>
>> Cc: Ian Molton <spyro@xxxxxxx>
>> ---
>>  drivers/mmc/host/Kconfig    |    4 ++--
>>  drivers/mmc/host/tmio_mmc.c |    2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> index b4cf691..9aae7f5 100644
>> --- a/drivers/mmc/host/Kconfig
>> +++ b/drivers/mmc/host/Kconfig
>> @@ -237,7 +237,7 @@ config MMC_SDRICOH_CS
>>   config MMC_TMIO
>>        tristate "Toshiba Mobile IO Controller (TMIO) MMC/SD function
>> support"
>> -       depends on MFD_TMIO
>> +       depends on MFD_TMIO || MFD_ASIC3
>>        help
>>          This provides support for the SD/MMC cell found in TC6393XB,
>> -         T7L66XB and also ipaq ASIC3
>> +         T7L66XB and also HTC ASIC3.
>> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
>> index 9f6e180..9f68c2f 100644
>> --- a/drivers/mmc/host/tmio_mmc.c
>> +++ b/drivers/mmc/host/tmio_mmc.c
>> @@ -10,7 +10,7 @@
>>  *
>>  * Driver for the MMC / SD / SDIO cell found in:
>>  *
>> - * TC6393XB TC6391XB TC6387XB T7L66XB
>> + * TC6393XB TC6391XB TC6387XB T7L66XB ASIC3
>>  *
>>  * This driver draws mainly on scattered spec sheets, Reverse engineering
>>  * of the toshiba e800  SD driver and some parts of the 2.4 ASIC3 driver
>> (4 bit
>
>

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/