Re: [PATCH] setup_affinity return 1 with failure

[AmÃrico Wang]

On Sun, Jun 14, 2009 at 11:33 PM, Yong Zhang<yong.zhang0@xxxxxxxxx> wrote:
> setup_affinity should return 1 when failure, then make checking in
> irq_select_affinity_usr() reasonable.
>
> Signed-off-by: Yong Zhang <yong.zhang0@xxxxxxxxx>

Looks good.

Reviewed-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

> ---
> Âkernel/irq/manage.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index aaf5c9d..8d2a992 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -137,7 +137,7 @@ int irq_set_affinity(unsigned int irq, const
> struct cpumask *cpumask)
> Âstatic int setup_affinity(unsigned int irq, struct irq_desc *desc)
> Â{
> Â Â Â Âif (!irq_can_set_affinity(irq))
> - Â Â Â Â Â Â Â return 0;
> + Â Â Â Â Â Â Â return 1;
>
> Â Â Â Â/*
> Â Â Â Â * Preserve an userspace affinity setup, but make sure that
> --
> 1.6.0.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/