Re: [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream device

[Brian Swetland]

On Sun, Jun 14, 2009 at 11:42 PM, Stefan
Schmidt<stefan@xxxxxxxxxxxxxxxxxx> wrote:
>> +
>> +#include <linux/mtd/nand.h>
>> +#include <linux/mtd/partitions.h>
>
> I see nothing in this file that needs mtd header files. Leftover from the "big"
> machine file? Please aslo check if the other header files are needed.
>
>> +#include "devices.h"
>> +#include "board-dream.h"
>> +
>> +static struct resource smc91x_resources[] = {
>> + Â Â [0] = {
>> + Â Â Â Â Â Â .start Â= 0x9C004300,
>> +       .end  Â= 0x9C004400,
>> + Â Â Â Â Â Â .flags Â= IORESOURCE_MEM,
>> + Â Â },
>> + Â Â [1] = {
>> + Â Â Â Â Â Â .start Â= MSM_GPIO_TO_INT(49),
>> +       .end  Â= MSM_GPIO_TO_INT(49),
>> + Â Â Â Â Â Â .flags Â= IORESOURCE_IRQ,
>> + Â Â },
>> +};
>> +
>> +static struct platform_device smc91x_device = {
>> +   .name      = "smc91x",
>> +   .id       = 0,
>> + Â Â .num_resources Â= ARRAY_SIZE(smc91x_resources),
>> +   .resource    = smc91x_resources,
>> +};
>
> I'm a bit confused here. The dream is the T-Mobile G1 and the Android dev phone,
> right? Is there really a network chip connected inside the device? Or is this a
> leftover from the developer board?

Oops.  Yeah that's definitely not present on G1.  I did a quick trim
from the halibut (qualcomm dev board) board file to get to a sane
starting point, but obviously didn't trim enough.

Reconstructing the board files a little at a time as peripherals are
added in various patch sets is going to be tedious, but probably a
good opportunity to clean them up a bit.

Thanks,

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/