Re: [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access

[Li Yang]

On Fri, Jun 12, 2009 at 9:58 PM, Kumar Gala<galak@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Jun 12, 2009, at 8:27 AM, Li Yang wrote:
>
>> On Thu, Jun 11, 2009 at 9:32 PM, Kumar Gala<galak@xxxxxxxxxxxxxxxxxxx>
>> wrote:
>>>
>>> On Jun 11, 2009, at 4:47 AM, Li Yang-R58472 wrote:
>>>
>>>>> On May 12, 2009, at 3:35 AM, Li Yang wrote:
>>>>>
>>>>>> Add the mapping functions used to support direct IO memory access of
>>>>>> rapidIO.
>>>>>>
>>>>>> Signed-off-by: Zhang Wei <zw@xxxxxxxxxxxxx>
>>>>>> Signed-off-by: Li Yang <leoli@xxxxxxxxxxxxx>
>>>>>
>>>>> Use inbnd/outbnd instead of inb/outb which make one think of
>>>>> byte level io accessors.
>>>>>
>>>>> As I look at this I don't think this is the correct API. ÂI
>>>>> think we should be using the DMA mapping API to hide these
>>>>> details. ÂThe concept of mapping like this seems to be more a
>>>>> function of FSL's Address translation/mapping unit (ATMU) than
>>>>> anything specific to the RIO bus standard.
>>>>
>>>> This is a separate RIO block level ATMU. ÂAlthough it looks like the
>>>> system level ATMU, system ATMU doesn't have the knowledge of rapidIO
>>>> target device ID. ÂThe mapping need to be dynamic, as it's easy to have
>>>> more RIO devices than the outbound windows.
>>>
>>> I understand that. ÂWhat I'm saying is the RIO block level ATMU is a
>>> Freescale specific detail and not part of any standard RIO bus
>>> programming
>>> model. ÂWe have mapping APIs that we can connect to for this via the DMA
>>> API
>>> layer.
>>
>> Ok, I see your point now. Do you mean dma_map_*() for DMA API layer?
>> But in my understanding the current dma_map_*() APIs are preparing
>> local memory for device to access which is similar to the inbound
>> case. ÂIs it suitable to also use them for mapping device's space for
>> CPU access? ÂCan you give an example of using this API for Address
>> Translation and Mapping purpose?
>
> Yes, I meant the dma_map_*() API. ÂAny system with a true IOMMU uses the
> dma_map_ layer as the way to do address translation.

IOMMU case is not very similar to the RapidIO scenario.  RapidIO
mapping is more like PCI address space mapping.

To be specific, the DMA API return dma_addr_t not the rapidIO address
type.  And they can only handle inbound mapping not both ways.  I
don't think the DMA API is competent enough to be used here for RIO
mapping.  Unless we have a more universal mapping API, it can be
justified to create its own API.

- Leo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/