Re: [BUGFIX][PATCH] memcg: fix page_cgroup fatal error in FLATMEMv2

[Pekka Enberg]

On Fri, 2009-06-12 at 20:45 +0530, Balbir Singh wrote:
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> > 
> > Now, SLAB is configured in very early stage and it can be used in
> > init routine now.
> > 
> > But replacing alloc_bootmem() in FLAT/DISCONTIGMEM's page_cgroup()
> > initialization breaks the allocation, now.
> > (Works well in SPARSEMEM case...it supports MEMORY_HOTPLUG and
> >  size of page_cgroup is in reasonable size (< 1 << MAX_ORDER.)
> > 
> > This patch revive FLATMEM+memory cgroup by using alloc_bootmem.
> > 
> > In future,
> > We stop to support FLATMEM (if no users) or rewrite codes for flatmem
> > completely.But this will adds more messy codes and overheads.
> > 
> > Changelog: v1->v2
> >  - fixed typos.
> > 
> > Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> > Tested-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
> > Reported-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> 
> I see you've responded already, Thanks!
> 
> The diff is a bit confusing, was Pekka's patch already integrated, in my version
> of mmotm, I don't see the alloc_pages_node() change in my source base.

Yes, my patch hit mainline on Thursday or so and this patch is now in as well.

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/