Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce andgpio_alt_func features to GPIOLIB

[Alek Du]

On Mon, 15 Jun 2009 17:50:23 +0800
Ben Dooks <ben-linux@xxxxxxxxx> wrote:

> > +enum gpio_trigger_t {
> > +	DETECT_LEVEL_LOW = -2,
> > +	DETECT_EDGE_FALLING = -1,
> > +	DETECT_DISABLE = 0,
> > +	DETECT_EDGE_RISING = 1,
> > +	DETECT_LEVEL_HIGH = 2,
> > +	DETECT_EDGE_BOTH = 3,
> > +};
> 
> wny not reuse the IRQ trigger types?
> 

Don't know it this is a good reason: the IRQ trigger name IRQ_TYPE_*
seems not good as DETECT_*. Since not all GPIO device would have IRQ line
connected to interrupt controller -- some of them just set a trigger bit
when detection happens.

Thanks,
Alek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/