RE: [PATCH] cpumask: avoid playing with cpus_allowed in powernow-k8.c

[Langsdorf, Mark]

> cpumask: avoid playing with cpus_allowed in powernow-k8.c
>     
> It's generally a very bad idea to mug some process's cpumask: it could
> legitimately and reasonably be changed by root, which could break us
> (if done before our code) or them (if we restore the wrong value).
>     
> I did not replace powernowk8_target; it needs fixing, but it grabs a
> mutex (so no smp_call_function_single here) but Mark points out it can
> be called multiple times per second, so work_on_cpu is too heavy.
>     
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> To: davej@xxxxxxxxxx
> To: cpufreq@xxxxxxxxxxxxxxx
> Cc: mark.langsdorf@xxxxxxx

I ran this over the weekend on a 24 core box without
any issues.  Please commit.

Acked-by: Mark Langsdorf <mark.langsdorf@xxxxxxx>
Tested-by: Mark Langsdorf <mark.langsdorf@xxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/