Re: [PATCH 0/3] ksm: write protect pages from inside ksm

[Hugh Dickins]

On Mon, 15 Jun 2009, Izik Eidus wrote:
> 
> So you dont have mmlist at all?, Good i think i found another problems with
> the usage the RFC made with the mmlist,
> Do you mind to send me the patch that move into diffrent mm list? or you still
> want to wait?

I'd really prefer to wait, there are too many questions I should
resolve one way or another now I can test again e.g. do we need
to put children on to the list when forking or not?

But don't let me hold you up: if you believe you've problems sharing
the mmlist, go ahead and separate out - I called the KSM one ksm_mmlist
(surprise!), hanging off init_mm.ksm_mmlist in the same way mmlist does.
And then you can get rid of the MMF flags etc (I've set aside your 4/4
as not something to get into right now - probably the release after).

At present I'm still using mmlist_lock, but that's probably a mistake:
we don't really want to have to consider unrelated lock ordering
constraints, a ksm_mmlist_lock would be better for now.

None of which precludes someone coming along later and combining
ksm_mmlist with mmlist in order to save space: but for now I
think we do better to keep them separate, and it sounds like
you've seen a strong reason for that.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/