Re: [PATCH 2/3] [ARM] msm: make debugging UART (for DEBUG_LL) configurable

[Brian Swetland]

On Mon, Jun 15, 2009 at 6:20 AM, Pavel Machek<pavel@xxxxxx> wrote:
> Hi!
>
>> Signed-off-by: Brian Swetland <swetland@xxxxxxxxxx>
>> ---
>> Âarch/arm/mach-msm/Kconfig          Â|  24 ++++++++++++++++++++++++
>> Âarch/arm/mach-msm/include/mach/debug-macro.S | Â 25 ++++++++++++++++++-------
>> Âarch/arm/mach-msm/include/mach/msm_iomap.h  |  12 ++++++++++++
>> Âarch/arm/mach-msm/include/mach/uncompress.h Â| Â Â7 +++++++
>> Âarch/arm/mach-msm/io.c            |  Â3 +++
>> Â5 files changed, 64 insertions(+), 7 deletions(-)
>
> I'm not sure if this is appropriate for mainline at this point. It
> seems like few people have debug cable at this point...
>
>> +config MSM_DEBUG_UART
>> + Â Â int
>> + Â Â default 1 if MSM_DEBUG_UART1
>> + Â Â default 2 if MSM_DEBUG_UART2
>> + Â Â default 3 if MSM_DEBUG_UART3
>
> ...and those that do, have it at fixed uart, no?

Well, I'd like to support the SoC generally, not just Dream -- it's
used in a bunch of different devices, and there's nothing that forces
you to use UART3 everywhere (I certainly have seen some 7k hardware
that uses UART1 as the debug serial port).

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/