Re: [RESEND][PATCH] input: Added TSC2003

[Richard Röjfors]

On 09-06-15 20.10, Trilok Soni wrote:
> Hi,
> 
> On Mon, Jun 15, 2009 at 8:39 PM, Richard
> Röjfors<richard.rojfors.ext@xxxxxxxxxxxxxxx> wrote:
>> Supplied is a driver for the TSC2003. There is actually a driver for TSC2007 which can be used in some cases.
>> The platform struct is reused from the TSC2007.
>> There is a big difference in the implementation between the drivers, this one does not use HR timers.
>> The TSC2007 driver performs synchronous I2C in the timer callback (SW IRQ context) which is bad when
>> the I2C driver is interrupt driven.
>>
> 
> Meaning? I think I2C transaction can sleep.

Yes that's what it means, and that's bad in a HR timer callback.

> I don't see (right now)
> need for two drivers. TSC2003 id was added to TSC2007. If you think
> TSC2007 doesn't provide enough support for it, then please add that in
> TSC2007 driver itself. We don't need create another driver it seems.

The chips are actually compatible (when it comes to the touchscreen functionality).

So you are true, the tsc2007 can be modified, I didn't added support for
the other pins anyway.

Actually I don't have access to any tsc2007, so I can't verify it on the newer chip.
I will go on and propose a patch.

--Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/