Re: [gpm] [PATCH 2.6.29] eeepc-laptop: report brightness controlevents via the input layer
From: Alan Jenkins
Date: Tue Jun 16 2009 - 04:34:51 EST
Richard Hughes wrote:
> On Mon, Jun 15, 2009 at 9:09 AM, Alan
> Jenkins<alan-jenkins@xxxxxxxxxxxxxx> wrote:
>> So during step iii) I think you see the firmware
>> increase the brightness, then g-p-m decrease the brightness, and then
>> g-p-m catches up and the brightness increases again.
> Sorry for not responding sooner, been moving house.
> I don't think the kernel driver should modify the brightness itself,
> as that's applying policy. Is this is left to userspace then we can
> put on policy such as "don't allow brightness to be set below 30%" or
> "automatically set the brightness using a ambient light sensor, and
> use the brightness keys to set ambient thresholds".
> Doing this policy in the driver is the wrong thing to do IMO.
The driver doesn't. As far as we know, none of them do. Firmware does.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/