Re: [PATCH] regulator: add check index of wm8350->pmic.pdev[]

From: Liam Girdwood
Date: Tue Jun 16 2009 - 05:15:48 EST


On Mon, 2009-06-15 at 22:30 +0200, Roel Kluin wrote:
> Ensure that reg is within the bounds of array wm8350->pmic.pdev[].
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350-regulator.c
> index 771eca1..c806259 100644
> --- a/drivers/regulator/wm8350-regulator.c
> +++ b/drivers/regulator/wm8350-regulator.c
> @@ -1419,6 +1419,8 @@ int wm8350_register_regulator(struct wm8350 *wm8350, int reg,
> {
> struct platform_device *pdev;
> int ret;
> + if (reg < 0 || reg >= NUM_WM8350_REGULATORS)
> + return -EINVAL;
>
> if (wm8350->pmic.pdev[reg])
> return -EBUSY;

Applied.

Thanks.

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/