Re: [PATCH 05/17] Blackfin: convert to generic checksum code

[Mike Frysinger]

On Mon, Jun 15, 2009 at 07:04, Arnd Bergmann wrote:
> On Sunday 14 June 2009, Mike Frysinger wrote:
>> The Blackfin port only implemented an optimized version of the
>> csum_tcpudp_nofold function, so convert everything else to the new
>> generic code.
>
> Have you tested this one well? I was as careful as possible with the
> version I added, but it was basically only tested on microblaze, which
> has a different endianess from blackfin. Some areas of the code may be
> sensitive to this.

networking still worked on my BF537-STAMP, but that isnt a very big
test.  i'll keep it locally until we can regression test it harder.

although these kind of issues sounds like a good reason to add some
internal testing code for people to optionally enable ... make sure
things work across endians/bit sizes/assorted changes & improvements
...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/