Re: [bug] WARNING: at drivers/char/tty_io.c:1266tty_open+0x1ea/0x388()

[Alan Cox]

> I have applied your patch from yesterday (attached further below for 
> reference) and the SLAB corruption has not triggered - instead i'm 
> now getting this warning, after 96 reboots

That one is interesting btw - however its not a new bug. The WARN_ON()
was added in the new patches to catch cases where the tty open/close
locking was broken and see if all the ldisc related ones were nailed.

Apparently on a very SMP box they are not. It's not however a new bug -
just the result of checking for the problem.

+        WARN_ON(!test_bit(TTY_LDISC, &tty->flags));


..

which means that someone cleared the ldisc behind our back despite us
holding tty_mutex. That would suggest a hangup/reopen race which
shouldn't be too hard to find.

Dunno what you feed your SMP box but its very useful 8)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/