Re: [PATCH] PCI PM: Fix handling of devices without PM support bypci_target_state()

From: Jesse Barnes
Date: Tue Jun 16 2009 - 15:18:38 EST


On Sun, 14 Jun 2009 21:25:02 +0200
"Rafael J. Wysocki" <rjw@xxxxxxx> wrote:

> From: Rafael J. Wysocki <rjw@xxxxxxx>
>
> If a PCI device is not power-manageable either by the platform, or
> with the help of the native PCI PM interface, pci_target_state() will
> return either PCI_D3hot, or PCI_POWER_ERROR for it, depending on
> whether or not the device is configured to wake up the system. Alas,
> none of these return values is correct, because each of them causes
> pci_prepare_to_sleep() to return error code, although it should
> complete successfully in such a case.
>
> Fix this problem by making pci_target_state() always return PCI_D0
> for devices that cannot be power managed.
>
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> ---
> Hi Jesse,
>
> I think this is 2.6.31 material, probably -stable too.

Applied to my linux-next branch, thanks.

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/