Re: [PATCH/RFC] Acer Aspire One fan control resume fix,improvements

[Andreas Mohr]

Hi,

On Tue, Jun 16, 2009 at 07:47:02AM -0400, Ed Tomlinson wrote:
> Please add this to the kernel now.  I have been using version of this on my wife's
> acer since I installed linux on it.  Its been doing its job as adverstised.  This is not
> a core feature - its a driver.  It works.  Why not add it?

Seconded. Better not wait 18 months this time.

This being said, I'm unfortunately _still_ experiencing the resume issue (unexpected fan
state) from time to time after resume. Really needs more investigation
to get that fixed somehow, eventually.

Also, the pre_suspend_kernelmode variable is superfluous indeed, as mentioned this
can be simplified.

Atom emergency shutdown works fine on my machine (blocked fan sometimes,
going tick-tick-tick on boot etc., nice way to test this BIOS feature ;),
thus given this extra protection I believe the driver can be committed as is
anyway, nevermind any remaining driver issues which _might_ perhaps
eventually still exist.

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/