Re: [PATCH 0/1] Recurse when searching for empty slots in resourcestrees

From: Linus Torvalds
Date: Wed Jun 17 2009 - 00:19:32 EST




On Wed, 17 Jun 2009, Andrew Patterson wrote:
>
> This looks functionally equivalent to the current code.

Absolutely. It's only meant to add the call chains for all the resource
additions, so that we could see how that buggy 'c2' resource gets added as
a parent to 'c3' (when it should be the other way around).

> I get way too much output to be useful. I can log the serial port if we
> need it all, or I can change it to just look at the buses in question if
> desired.

Sure. Or increase CONFIG_LOG_BUF_SHIFT to 22 or somethng insane like that
(so that it logs up to 4MB of messages).

But yeah, if you just make it smarter, and only do that WARN() thing for
resources that match "PCI Bus" at the beginning of the name, that should
be plenty good enough.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/