Re: [bug] __nf_ct_refresh_acct(): WARNING: at lib/list_debug.c:30__list_add+0x7d/0xad()

From: David Miller
Date: Wed Jun 17 2009 - 07:35:46 EST


From: Ingo Molnar <mingo@xxxxxxx>
Date: Wed, 17 Jun 2009 13:08:03 +0200

>
> * Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
>
>> IPS_CONFIRMED_BIT is set under nf_conntrack_lock (in __nf_conntrack_confirm()),
>> we probably want to add a synchronisation under ct->lock as well,
>> or __nf_ct_refresh_acct() could set ct->timeout.expires to extra_jiffies,
>> while a different cpu could confirm the conntrack.
>>
>> Following patch as RFC
>
> A quick test suggests that it seems to works here - thanks Eric!

Patrick, please take a quick look at Eric's fix. I'd like to
apply it quickly if it looks good to you.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/