Re: [PATCH] Request driver inclusion - acer aspire one fan control

From: Andreas Mohr
Date: Wed Jun 17 2009 - 08:20:34 EST


Hi,

On Wed, Jun 17, 2009 at 12:14:35AM +0200, Peter Feuerer wrote:
> Hi,
>
> Andreas, I applied and reviewd your patch and additionally changed following things:
> o added "acerhdf_enable_kernelmode" which is the opposite of your "acerhdf_revert_to_bios_mode".

Good idea.

> o suspend stops and resume starts the kernelmode in a clean way

Didn't someone argue that pre_suspend_kernelmode was unnecessary?
It's still in there. (could be submitted together with the
Kconfig ACPI depends ;)

> I tested the patch with current linus git. Unfortunately does the current state of the kernel freeze my a1 after suspend/resume randomly (also without acerhdf). Anyways I was able to do 11 suspend / resume cycles with acerhdf loaded and kernelmode=on.

Oh no, not again.

Thanks!

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/