Re: [PATCH]x86-tsc.c : fix compile warning

[Subrata Modak]

On Wed, 2009-06-17 at 18:23 +0200, Ingo Molnar wrote:
> * Frans Pop <elendil@xxxxxxxxx> wrote:
> 
> > On Wednesday 17 June 2009, Ingo Molnar wrote:
> > > Ah, and you fixed in what a superior way: you improved the code in
> > > the process :-) This is how warnings should be fixed really.
> > 
> > Hmm. Did you also see Pavel's reply to that patch [1]:
> > ! But that's a bug to be fixed, I'd say? ... actually I believe you are
> > ! introducing a bug here. Yes, old code would put random numbers in
> > ! loops_per_jiffy_ref for !CPUFREQ_CONST_LOOPS, but you are introducing
> > ! oops there.
> > 
> > Was his comment incorrect?
> > 
> > Cheers,
> > FJP
> > 
> > [1] http://lkml.org/lkml/2009/5/24/159
> 
> hm, Pavel seems right - i missed that. Subrata, mind sending an 
> updated patch?

Hmmm. I would try doing that soon.

Regards--
Subrata

> 
> Thanks,
> 
> 	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/