Re: [PATCH for -mm] getrusage: fill ru_maxrss value

[KOSAKI Motohiro]

> On Mon, 6 Apr 2009 08:22:07 +0100 (BST)
> Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
> 
> > On Mon, 6 Apr 2009, KOSAKI Motohiro wrote:
> > > 
> > > > I'm worrying particularly about the fork/exec issue you highlight.
> > > > You're exemplary in providing your test programs, but there's a big
> > > > omission: you don't mention that the first test, "./getrusage -lc",
> > > > gives a very different result on Linux than you say it does on BSD -
> > > > you say the BSD fork line is "fork: self 0 children 0", whereas
> > > > I find my Linux fork line is "fork: self 102636 children 0".
> > > 
> > > FreeBSD update rusage at tick updating point. (I think all bsd do that)
> > > Then, bsd displaing 0 is bsd's problem :)
> > 
> > Ah, thank you.
> > 
> > > 
> > > Do I must change test program?
> > 
> > Apparently somebody needs to, please; though it appears to be already
> > well supplied with usleep(1)s - maybe they needed to be usleep(2)s?
> > 
> > And then change results shown in the changelog, and check conclusions
> > drawn from them (if BSD is behaving as we do, it should still show
> > maxrss not inherited over fork, but less obviously - the number goes
> > down slightly, because the history is lost, but nowhere near to zero).
> > 
> 
> afaik none of this happened, so I have the patch on hold.

Grr, my fault.
I recognize it. sorry.





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/