Re: [PATCH 2/1 v2] Re: [BUG] fib_tries related Oops in 2.6.30
From: David Miller
Date: Wed Jun 17 2009 - 21:57:16 EST
From: Jarek Poplawski <jarkao2@xxxxxxxxx>
Date: Mon, 15 Jun 2009 18:08:01 +0200
> ipv4: Fix fib_trie rebalancing, part 2
> My previous patch, which explicitly delays freeing of tnodes by adding
> them to the list to flush them after the update is finished, isn't
> strict enough. It treats exceptionally tnodes without parent, assuming
> they are newly created, so "invisible" for the read side yet.
> But the top tnode doesn't have parent as well, so we have to exclude
> all exceptions (at least until a better way is found). Additionally we
> need to move rcu assignment of this node before flushing, so the
> return type of the trie_rebalance() function is changed.
> Reported-by: Yan Zheng <zheng.yan@xxxxxxxxxx>
> Signed-off-by: Jarek Poplawski <jarkao2@xxxxxxxxx>
Applied, thanks a lot Jarek.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/