Re: [PATCH 12/16] x86, mce: squash mce_intel.c into therm_throt.c

[huang ying]

2009/6/15 Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>:
> move intel_init_thermal() into therm_throt.c
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>
> ---
> Âarch/x86/kernel/cpu/mcheck/Makefile   Â|  Â2 +-
> Âarch/x86/kernel/cpu/mcheck/mce_intel.c  |  73 ------------------------------
> Âarch/x86/kernel/cpu/mcheck/therm_throt.c | Â 66 +++++++++++++++++++++++++++
> Â3 files changed, 67 insertions(+), 74 deletions(-)
> Âdelete mode 100644 arch/x86/kernel/cpu/mcheck/mce_intel.c

Why we need this patch? I think the design principle behind MCE is to
separate vendor/cpu specific code into different files. At least
#ifdef CONFIG_X86_MCE_INTEL should be used around moved code.

Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/