[PATCH] tracing: Use DECLARE_COMPLETION_ONSTACK() for stack completion variable

From: Matt Fleming
Date: Thu Jun 18 2009 - 07:10:12 EST


init_completion() is for use with dynamically allocated
completions. The 'isrt' completion is not dynamically allocated but is
allocated on the stack, so use the appropriate macro for lockdep's
benefit.

Signed-off-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
---
kernel/trace/trace_selftest.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
index 00dd648..45e64e1 100644
--- a/kernel/trace/trace_selftest.c
+++ b/kernel/trace/trace_selftest.c
@@ -586,12 +586,10 @@ trace_selftest_startup_wakeup(struct tracer *trace, struct trace_array *tr)
{
unsigned long save_max = tracing_max_latency;
struct task_struct *p;
- struct completion isrt;
+ DECLARE_COMPLETION_ONSTACK(isrt);
unsigned long count;
int ret;

- init_completion(&isrt);
-
/* create a high prio thread */
p = kthread_run(trace_wakeup_test_thread, &isrt, "ftrace-test");
if (IS_ERR(p)) {
--
1.6.3.2.306.g4f4fa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/