Re: [KVM PATCH v7 1/2] KVM: make io_bus interface more robust

[Avi Kivity]

On 06/16/2009 04:42 PM, Gregory Haskins wrote:
> +
> +/* assumes kvm->lock held */
> +void kvm_io_bus_unregister_dev(struct kvm_io_bus *bus,
> +			       struct kvm_io_device *dev)
> +{
> +	int i;
> +
> +	for (i = 0; i<  bus->dev_count; i++) {
> +
> +		if (bus->devs[i] == dev) {
> +			int j;
> +
> +			/* backfill the hole */
> +			for (j = i; j<  bus->dev_count-1; j++)
> +				bus->devs[j] = bus->devs[j+1];
> +
> +			bus->dev_count--;
> +
> +			break;
>    

Could be simplified to

    if (bus->devs[i] == dev) {
        bus->devs[i] = bus->devs[--bus->dev_count];
        return;
    }

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/