Re: [PATCH v2] ftrace: change the export format oftrace_kfree_skb()

[Steven Rostedt]

On Thu, 18 Jun 2009, Neil Horman wrote:
> > 
> > diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h
> > index 1e8fabb..2496060 100644
> > --- a/include/trace/events/skb.h
> > +++ b/include/trace/events/skb.h
> > @@ -7,6 +7,71 @@
> >  #undef TRACE_SYSTEM
> >  #define TRACE_SYSTEM skb
> >  
> > +#define protocol_name(protocol) { protocol, #protocol }
> > +#define show_protocol_name(val)					\
> > +	__print_symbolic(val,					\
> 
> Don't you need to include ftrace.h to pull in the __print_symbolic definition?
> Or is that always guaranteed to be included from tracepoint.h?

Its use is in one of the fields of TRACE_EVENT that are only used by 
define_trace.h. All other users will ignore it.

#define TRACE_EVENT(name, proto, args, struct, assign, print)	\
	DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))

Only name, proto, args is used. The define_trace.h will include 
trace/ftrace.h and that will use the struct, assign and print args.

So the answer is "no" ;-)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/