Re: [gpm] [PATCH 2.6.29] eeepc-laptop: report brightness control events via the input layer
From: Alan Jenkins
Date: Thu Jun 18 2009 - 09:34:11 EST
On 6/16/09, Richard Hughes <hughsient@xxxxxxxxx> wrote:
> On Tue, Jun 16, 2009 at 10:44 AM, Corentin
> Chary<corentin.chary@xxxxxxxxx> wrote:
>> Ok, so we just need to patch this file :
>> But I'm not sure how to do it to make it works on all Eeepc.
> Well, really we want to match "classes of eeepc", so matching with
> prefix might be a good idea.
Yes please! I see the 701 is (just added?) on the list, but this
applies to any hardware which is driven by the eeepc-laptop driver.
There is no "brightness up key" or "brightness down key" notification
recognised by the driver, only "brightness level is now equal to X".
Btw, I looked at other drivers and fujistsu-laptop is implemented in
the same way.
I guess the problem is the DMI manufacturer and product name don't
mention "EeePC". At least on my model, the serial number starts with
"EeePC-", so we _could_ try to use that.
But I hope there's a nicer solution. Corentin, do you think it would
be correct to apply this quirk to _all_ Asus laptops?
At the moment asus-laptop doesn't generate brightness events. The
deprecated asus-acpi driver generates brightness events (via the old
procfs interface). But the BR_UP/BR_DOWN events carry an absolute
brightness value; it strongly suggests that the firmware modifies the
brightness. asus-acpi uses the brightness value to update a generic
backlight device - so we already rely on the value being correct,
otherwise g-p-m's heuristic won't work.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/