Re: [PATCH 12/16] x86, mce: squash mce_intel.c into therm_throt.c

From: H. Peter Anvin
Date: Thu Jun 18 2009 - 12:30:25 EST


huang ying wrote:
>>
>> You can pull out "codes may not be shared" from therm_throt.c and
>> put it again into mce_intel.c (that was mce_intel_64.c). But I
>> believe it is not needed now, until another code is available.
>> Or you can rename therm_throt.c to thermal_intel.c or so for a while.
>
> I think thermal_intel.c is better.
>

Actually intel_thermal.c and intel_cmci.c would probably be the right
naming. The mce_ prefix for files in this directory is redundant; so
for vendor-specific features the vendor is the higher order organizing
factor.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/