On Tue, 2009-06-16 at 16:49 -0400, Eric Paris wrote:
On Mon, 2009-06-15 at 18:42 -0300, Rajiv Andrade wrote:
Wait what? we refuse to work around buggy hardware that is shipping in2- Forget manufacturer_id and base the decision on the PNP_ID as davidYes, it wasn't hard, at all, just get the id with to_pnp_dev(dev)->id.
suggested. I previously considered it but since it would end up in
modifying tpm_tis_init() prototype (struct device * to struct pnp_dev *)
and then wouldn't work when loading as a module with force option on, so
I moved to the manufacturer_id approach.
I'll get back to #2 meanwhile and post the patch, seems not hard to
However, the chip is buggy, there's no reason to make a compliant
upstream code modify its behavior just due an 'exception' for a not
No need to worry about it too though, the workaround is available as I
pointed earlier (Seiji's)...
LOTS of hardware (all the currently shipping lenovo thinkpads) even
though the fix is easy? This doesn't sound right.....
I didn't refuse to work on it... That depends on the meaning in this
context. My point is: not make an exception in the upstream code due a
buggy hardware (that's what that easy 'fix' does). Other than David's
patches, there is a workaround available as I said:
The only Lenovo thinkpad model I know that has it is the X200. If Intel
is indeed still shipping it buggy (therefore more and more unaware users
are buying it), that's another story. Can you confirm that?
The best would be to hear something from Intel, if they are planning to
fix it, discontinue it, do nothing about it or anything else.
Do you know how to do it or if that's possible?
More, that's only one bug. With the workaround in hands and being able
to load the module, did you run any regression tests? (Sorry for asking
that, but, again, I don't have this chip):
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
tpmdd-devel mailing list