Re: [PATCH] kmemleak: use pr_fmt

[Joe Perches]

On Fri, 2009-06-19 at 10:53 +0100, Catalin Marinas wrote:
> Thanks for the patch. It missed one pr_info case (actually invoked via
> the pr_helper macro).

This change will affect the seq_printf uses.
Some think the seq output should be immutable.
Perhaps that's important to you or others.

An option is to change the print_helper
pr_info to a printk(KERN_INFO and not change
any uses of print_helper

#define print_helper(seq, x...)	do {	\
	struct seq_file *s = (seq);	\
	if (s)				\
		seq_printf(s, x);	\
	else				\
		printk(KERN_INFO x);	\
} while (0)

> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > + 
>    ^ - empty space at the end of the line (git told me about it)

Thanks for letting me know.  I'll fix my tools.

Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/