Re: [GIT PULL] core kernel fixes

From: Linus Torvalds
Date: Sat Jun 20 2009 - 15:02:23 EST

On Sat, 20 Jun 2009, Linus Torvalds wrote:
> On x86, the natural way to do what you want done is ONE SINGLE
> INSTRUCTION! As far as I can tell, the above crazy function is 100%
> equivalent to this:
> asm __inline__("lock ; addl $0,%0":"+m" (*uaddr): :"memory", "cc");
> which really makes me think that using "get_user_pages_fast()" for it is
> some truly crazy crap.

We could also take the opposite approach - knowing that this is called
only when the page doesn't exist, and just doing

vma = find_vma(..)
if (vma && vma->vm_start <= address)
ret = handle_mm_fault(mm, vma, address, 1);
return (ret & VM_FAULT_ERROR) ? -EFAULT : 0;

or something like that. Again, that looks saner than using
get_user_pages() for this and then dropping the page.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at