Re: [PATCH -tip] x86: mm/hugetlbpage.c fix style problems
From: Jaswinder Singh Rajput
Date: Sun Jun 21 2009 - 07:40:41 EST
On Sun, 2009-06-21 at 13:22 +0200, Ingo Molnar wrote:
> this change is not an improvement either.
> Plus at a first glance that file has a couple of other problems as
> well beyond trivial style issue:
> - dead code which should be removed
> - a 64-bit only boot option that should probably be extended to
> 32-bit as well
> - insanely long function names with local scope, causing ugly
> and more style issues as well:
> - various inconsistent capitalizations in comment blocks
> - some other small details as well
> Lets try to do a genuinely big and comprehensive forward step that
> addresses all these issues (and any other issues that are in that
> file), ok?
ok, I will try.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/