[PATCH] sound: fix check for return value in snd_pcm_hw_refine

From: Mariusz Kozlowski
Date: Sun Jun 21 2009 - 14:35:38 EST


'params' is a pointer and looking at the code this probably should be a check
for ioctl return value.


Signed-off-by: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 84da3ba..ac2150e 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -320,7 +320,7 @@ int snd_pcm_hw_refine(struct snd_pcm_substream *substream,
snd_mask_max(&params->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) {
changed = substream->ops->ioctl(substream,
- if (params < 0)
+ if (changed < 0)
return changed;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/