Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support

From: Avi Kivity
Date: Mon Jun 22 2009 - 10:28:03 EST


On 06/22/2009 04:13 PM, Michael S. Tsirkin wrote:
Right, understood. What I meant specifically is that if the (void*)val
pointer is allowed to be misaligned we are in trouble ;). I haven't
studied the implementation in front of the MMIO callback recently, but I
generally doubt thats the case. More than likely this is some buffer
that was kmalloced and that should already be aligned to the machine word.

Kind Regards,
-Greg


Yes, from what I saw of the code I think it can be BUG_ON.
Avi?

Yes, BUG_ON is safe here.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/