Re: [patch] Remove tty low_latency flag setting from drivers/char/

[Alan Cox]

> Remove tty low_latency flag setting from drivers/char/.
> 
> The kernel oopses if this flag is set.

ipwireless_network_packet_received is not called from an IRQ path but
from a sleeping one. Please provide a trace of whatever you see failing
with that one as it should be fine and that isn't a bug fix. It may or
may not need low_latency but something else is wrong if it matters.

> 
> Signed-off-by: Chuck Ebbert <cebbert@xxxxxxxxxx>
> 
> --- linux-2.6.30.noarch.orig/drivers/char/nozomi.c
> +++ linux-2.6.30.noarch/drivers/char/nozomi.c
> @@ -1591,8 +1591,6 @@ static int ntty_open(struct tty_struct *
>  
>  	/* Enable interrupt downlink for channel */
>  	if (port->port.count == 1) {
> -		/* FIXME: is this needed now ? */
> -		tty->low_latency = 1;

This one is correct.

> --- linux-2.6.30.noarch.orig/drivers/char/mxser.c
> +++ linux-2.6.30.noarch/drivers/char/mxser.c
> @@ -1048,8 +1048,6 @@ static int mxser_open(struct tty_struct 
>  	if (retval)
>  		return retval;
>  
> -	/* unmark here for very high baud rate (ex. 921600 bps) used */
> -	tty->low_latency = 1;
>  	return 0;
>  }

As is this
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/