Re: [PATCH 1/2] serial: bfin_5xx: add missing spin_lock init

[Andrew Morton]

On Fri, 12 Jun 2009 20:48:12 -0400
Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> The Blackfin serial driver never initialized the spin_lock that is part of
> the serial core structure, but we never noticed because spin_lock's are
> rarely enabled on UP systems.  Yeah lockdep and friends.
> 

I'm sitting here wondering if we need this in -stable, but the changlog
failed to provide sufficient information to determine this.

>  drivers/serial/bfin_5xx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
> index e2f6b1b..d7fcca1 100644
> --- a/drivers/serial/bfin_5xx.c
> +++ b/drivers/serial/bfin_5xx.c
> @@ -1110,6 +1110,7 @@ static void __init bfin_serial_init_ports(void)
>  	bfin_serial_hw_init();
>  
>  	for (i = 0; i < nr_active_ports; i++) {
> +		spin_lock_init(&bfin_serial_ports[i].port.lock);
>  		bfin_serial_ports[i].port.uartclk   = get_sclk();
>  		bfin_serial_ports[i].port.fifosize  = BFIN_UART_TX_FIFO_SIZE;
>  		bfin_serial_ports[i].port.ops       = &bfin_serial_pops;

It _should_ be possible to do this initialisation at compile-time.  But
I expect it would be hard and/or ugly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/