Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized beforeSLAB
From: Pekka Enberg
Date: Tue Jun 23 2009 - 01:59:44 EST
On Tue, 23 Jun 2009, Benjamin Herrenschmidt wrote:
> > + /*
> > + * This initializes the mutex used by get/put_online_cpus()
> > + * which is used by SLAB
> > + */
> > + cpu_hotplug_init();
On Mon, 2009-06-22 at 19:29 -0700, Linus Torvalds wrote:
> Oh fudge it.
> Why not get rid of that stupid thing, rather than have that subtle
> dependency and a comment for it.
> IOW, does this simpler alternative also work?
> When given the choice of simplifying and removing code, always do so.
> Static initializers are much nicer than having to worry about when
> something gets initialized, no?
Looks good to me. Thanks for fixing it up, Linus!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/